Improve comment about what the '**' glob pattern does. #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve comment about what the '**' glob pattern does.
ben
reviewed
Apr 20, 2017
| doc/*.txt | ||
| # ignore all .pdf files in the doc/ directory | ||
| # ignore all .pdf files in the doc/ directory or in the sub directories of doc/ |
There was a problem hiding this comment.
Hmm. What about this instead?
# ignore all .pdf files anywhere inside the doc/ directory
There was a problem hiding this comment.
I think it is nicer to have the word "sub directory" in there somewhere. To make the association with '**' stronger and remove any ambiguity. After all that is what it is all about, which you might not know if you were seeing it for the first time.
There was a problem hiding this comment.
OK, how about this then:
# ignore all .pdf files in the doc/ directory or any of its subdirectories
There was a problem hiding this comment.
Maybe this is logically "more true"? :D
# ignore all .pdf files in the doc/ directory
orand any of its subdirectories
chaitanyagurrapu
force-pushed
the
patch-1
branch
3 times, most recently
from
cf4f783 to
d93f11b
Compare
chaitanyagurrapu
force-pushed
the
patch-1
branch
from
d93f11b to
fc5ed3c
Compare
|
Updated accordingly. |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve comment about what the '**' glob pattern does.