Minor text changes to First-time Git setup #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wturrell
commented
May 14, 2017
wturrell
commented
- Text referred to "either" editor when several were listed
- Make the "Warning" less vague/confusing (I interpret it as being about what could happen if Git can't find an editor)
- Text referred to "either" editor when several were listed - Make the "Warning" less vague/confusing (I interpret it as being about what could happen if Git can't find an editor)
ben
requested changes
May 15, 2017
| ==== | ||
| You may find, if you don't setup an editor like this, you will likely get into a really confusing state when they are launched. | ||
| Such example on a Windows system may include a prematurely terminated Git operation during a Git initiated edit. | ||
| You may find, if you don't setup your editor like this, you get into a really confusing state when Git attempts to launch it. An example on a Windows system may include a prematurely terminated Git operation during a Git initiated edit. |
There was a problem hiding this comment.
Can you put these two sentences on separate lines? It makes diffs much more readable in the future.
Add a line-break so sentences are on separate lines.
ben
approved these changes
May 15, 2017
|
Brilliant, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.