Changes for chapter 7 #753
Conversation
The sentence wasn't consistent and was corrected.
The reflog output wasn't reflecting
the new message shown by git for merges
Made the example command reflect the command that needs to be used by the user.
A sentence thatput the main point at the end didn't seem nice and thus the point was specified earlier followed by it's outcome A sample code was made better as it seems to have the same effect
* Removed time related words * Split a sentence to improve readability
| It is called with the `-L` option to `git log` and will show you the history of a function or line of code in your codebase. | ||
| This can be really helpful. | ||
| It is called with the `-L` option to `git log`. | ||
| It will show you the history of a function or line of code in your codebase. |
There was a problem hiding this comment.
The structure here is kind of stilted. Instead of these three sentences, what about just one:
Simply run
git logwith the-Loption, and it will show you the history of a function or line of code in your codebase.
There was a problem hiding this comment.
That's much better and the change has been done 😄
The long sentences were merged into one short concise to increas readability.
|
@ben Any thoughts about the question in the description ? |
|
Ah, right, I somehow missed that at first. Your change sounds like an improvement. Go ahead and include it here, and we'll get this merged! |
|
Made the change but with a little modification. I guess it deserves review. The current sentence is,
BTW, sorry about that grammatical error in the commit message. Should have been careful. |
This PR adds a few changes to chapter 7 of the book that seemed good to me ;) Few more changes are to would possibly be made in a following PR. There's one change that I wanted to make in this PR but held it back to get comments regarding it. It's regarding the lines quoted below found in the Changing the Last Commit subsection of the Rewriting History section,
As far as I know, amending takes things in the current staging area and adds it to the snapshot of the last commit. So shouldn't the above sentence be rephrased as follows,