Skip to content

added instructions to build the book #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 16, 2017
Merged

added instructions to build the book #766

merged 5 commits into from
Jun 16, 2017

Conversation

aollier
Copy link
Contributor

@aollier aollier commented Jun 14, 2017 •
edited
Loading

closes #764.

aollier added 3 commits June 14, 2017 21:46
@aollier
added instructions to build the book
e473671 
It is required to make the images folder if it does not exists yet
and one wants to build the book with the asciidoctor command.
closes #764
@aollier
fixes the file format for images
0df4c91
@aollier
simply copy the files contained in the images folder of the book
897ea54
@ben
Copy link
Member

ben commented Jun 15, 2017

I like it. Let me know when you're ready to merge.

@aollier
Copy link
Contributor Author

aollier commented Jun 15, 2017 •
edited
Loading

Now I am ready to merge.
I started the command to copy images with find because it is what @bremenpl used whereas it was much simpler. I blame myself for not having thought of using so simply the cp command earlier.

@aollier
Copy link
Contributor Author

aollier commented Jun 15, 2017 •
edited
Loading

In fact I am not ready to merge because the next sentence is a proposal:

You can also use the following commands:

I propose

Use the following commands:

Do you agree ?

ben
ben reviewed Jun 15, 2017
View reviewed changes
README.asc Outdated
----

An alternative to calling the `bundle` command is to call directly the `asciidoctor` command.
If it is the first time you build the book, it is necessary to create the _images_ folder and fill it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If this is the first time you're building the book…" would be better.

@ben
Copy link
Member

ben commented Jun 15, 2017

I propose

Use the following commands:

👍

@ben
Copy link
Member

ben commented Jun 16, 2017

🎉

@ben ben merged commit c0b1671 into progit:master Jun 16, 2017
@aollier aollier deleted the book branch June 16, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben ben ben left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

images folder missing when creating pdf file

2 participants

@aollier @ben