Skip to content

Conversation

aollier
Copy link
Contributor

@aollier aollier commented Jun 17, 2017

Those images are no more used since a while:

$ git log -S'gitlab-broadcast.png' -1 --name-only
commit 9b73763f083c115eac9827837e81e89e6f48d098
Author: Ben Straub <ben@straub.cc>
Date:   Sun Mar 23 09:16:49 2014 -0700

    Trim and focus for GitLab content

en/book/04-git-server/chapter4.asc
# no longer used since this commit
$ git log -S'merging-workflows-4 2.png' --max-count=1 --name-only
# no result, never used
$ git log -S'blink-pull-request-open copy.png' --max-count=1 --name-only
# no result, never used
$ git log -S'blink-pull-request-open.png' --max-count=1 --name-only
commit 6b0acf02212703b98bb88adf0c47f7b55a336b18
Author: Scott Chacon <schacon@gmail.com>
Date:   Wed Oct 1 13:20:58 2014 +0200

    partially done with 6.2

book/06-github/sections/github-flow.asc
# no longer used since this commit
$ git log -Shubot.png --max-count=1 --name-only
commit 6b0acf02212703b98bb88adf0c47f7b55a336b18
Author: Scott Chacon <schacon@gmail.com>
Date:   Wed Oct 1 13:20:58 2014 +0200

    partially done with 6.2

book/06-github/sections/projects.asc
# no longer used since this commit

Every other images are still used.

@ben
Copy link
Member

ben commented Jun 17, 2017

👍🏼 thanks for doing this! I notice you're removing an image of Hubot too, did you run the log to check that one as well?

@aollier
Copy link
Contributor Author

aollier commented Jun 17, 2017

Yes I did, it is the last:

$ git log -Shubot.png --max-count=1 --name-only
commit 6b0acf02212703b98bb88adf0c47f7b55a336b18
Author: Scott Chacon <schacon@gmail.com>
Date:   Wed Oct 1 13:20:58 2014 +0200

    partially done with 6.2

book/06-github/sections/projects.asc
# no longer used since this commit

The file book/06-github/sections/projects.asc was removed at commit 6b0acf0, so the last reference to book/06-github/images/hubot.png too.

@aollier
Copy link
Contributor Author

aollier commented Jun 17, 2017

You can check that there is no more reference to hubot.png by running this command:

git grep --fixed-strings --files-with-matches 'hubot.png' \*.asc

This command returns no result.

@ben
Copy link
Member

ben commented Jun 17, 2017

Aha, I see it now. Sorry, hadn't had my coffee yet. Thanks!

@ben ben merged commit 72f4acd into progit:master Jun 17, 2017
@aollier aollier deleted the images branch June 17, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants