New architecture of the repository for manual building of the book. #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old architecture was needed for the building of the book by Atlas. Atlas O'Reilly's building chain (https://atlas.oreilly.com) is broken.
ben
approved these changes
Sep 4, 2017
|
Shame the output isn't as nice as Atlas, but this is definitely an improvement.
|
|
The output was already like that before the move of the images. I don't know the reason. Maybe the images need to be processed ? |
|
Since we're talking about images and the fact that they do not wok great atm, maybe it's the right time to include SVGs so anyone can edit them? They're currently in some paid Mac-only app if I recall correctly, and they do not seem that complex at all to re-create in SVG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old architecture was needed for the building of the book by Atlas.
Atlas O'Reilly's building chain (https://atlas.oreilly.com) is broken.