systemd config file uses full path to git binary. #924
Conversation
| Modify it to fit your needs and make sure provided user exists on the system. | ||
|
|
||
| Also, make sure that the Git binary is indeed located at `/usr/bin/git` and change the path if necessary. | ||
|
|
There was a problem hiding this comment.
Let's make this part of the paragraph just before it, I think it'll flow better that way.
There was a problem hiding this comment.
I wasn't sure about the formatting rules here. Since the two user-related sentences are split across separate paragraphs, it felt odd to attach something very different to one of the two.
There was a problem hiding this comment.
🤔
You might have noticed that Git daemon is started here with git as both group and user.
Modify it to fit your needs and make sure provided user exists on the system.
Also, make sure that the Git binary is indeed located at /usr/bin/git and change the path if necessary.
You know what? Let's make all of these the same paragraph. Oh, and can you add the word "the" between "make sure" and "provided user"?
As per @ben's suggestion, the three paragraphs dealing with adapting the systemd config to the system at hand have been compounded into one. I also got rid of a double "make sure" for style.
|
@ben Done. (Not sure if the commit itself triggers a notification; does it?) |
|
✨ |
|
It does, but it's always nice to get a message telling me that you're ready for another review. Thanks, and congrats on your first PR! |
Fixes #923