-
Notifications
You must be signed in to change notification settings - Fork 2k
Rework files #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework files #969
Conversation
Some more files tweaking is needed to allow correct generation of pdf and ebooks.
This helps reproducible build and fixes a regression in the latest master.
I can't speak to how difficult it is to setup, but I've seen both Circle CI and Travis CI provide good feedback when changes were introduced to a source tree that broke builds. Perhaps that could be implemented for this repo as well. Of course it might not help this particular problem unless there is a build flag that can be enabled to catch it. |
@deoren We're already using travis-ci to compile the books so that they are available for download from git-scm.com . It works great. What I'm looking for is a utility to check the resulting document for failures. I used epubcheck but it seems to miss some errors. That's better than nothing, but if something more reliable was available and if the pdf file could also be tested, that would make travis even more useful (specially for PRs). |
Gotcha. Unfortunately I don't know of anything, but if I stumble across something I'll be sure to share. |
@jnavila Not sure if it's helpful, but these are the latest warnings generated emitted when generating the files:
EDIT: Not related to the automated testing of formats. |
@ben I'm going to merge this now, because otherwise, merges will rapidly become hairy. |
Just checked with 80bd744. All seems good. Thank you! The two double def of xrefs warnings have gone. Can only see that unzipping epubs then parsing out xrefs and marrying up can be the only easy to go. Doing this for html seems the only option, too. Thanks for all this work! |
Slightly late 👍 . This is awesome, thanks everybody! |
This is rework of file hierarchy and names to adapt the book to the requirements of asciidoctor for ebooks and pdf, while retaining a working publishing toolchain at git-scm.com.
@deoren @rahrah I think I fixed the missing crosslinks from appendix C , which mysteriously haven't shown up with epubcheck. The ones in other chapters which passed through the transformation scripts were fixed as well.
I'd be very interested in a reliable automatic check of this stuff...