Fix ws/wss parsing so that SSL is actually used when you enter a wss URL #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progrium
added a commit
that referenced
this pull request
Dec 29, 2012
Fix ws/wss parsing so that SSL is actually used when you enter a wss URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current repository, when using a wss:// URL -- even when also manually specifying port 443 -- SSL is not actually used, because in client.py it constructs the URL over again and always uses "ws".
This commit makes the client aware of the given scheme, and adds some sane parsing rules in init.py so that it works the way it's expected in all cases -- with/without scheme and with/without port.