Fixed some path handling awkwardness from my previous changes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was pretty easy to create confusing situations where the lack of a
trailing '/' would cause counter intuitive error messages to be reported
due to path mismatch. For example, ws://echo.websocket.org and
ws://echo.websocket.org/ were being treated differently, with the former
producing malformed HTTP requests ("GET HTTP/1.1"). Likewise, the lack
of a trailing slash affected the server's behaviour with respect to path
matching as well.
progrium
added a commit
that referenced
this pull request
Oct 8, 2012
Fixed some path handling awkwardness from my previous changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.