Skip to content

Commit d27e676

Browse files
Addressed review comments
1 parent 5f0ee25 commit d27e676

15 files changed

+26
-25
lines changed

demo-notebooks/additional-demos/hf_interactive.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
],
9393
"source": [
9494
"# Create our cluster and submit\n",
95-
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\"\n",
95+
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
9696
"cluster = Cluster(ClusterConfiguration(name='hfgputest', \n",
9797
" namespace=\"default\",\n",
9898
" num_workers=1,\n",

demo-notebooks/additional-demos/local_interactive.ipynb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@
4848
},
4949
"outputs": [],
5050
"source": [
51-
"# Create our cluster and submit appwrapper\n",
51+
"# Create and submit our cluster\n",
52+
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
5253
"namespace = \"default\" # Update to your namespace\n",
5354
"cluster_name = \"hfgputest-1\"\n",
5455
"\n",

demo-notebooks/additional-demos/ray_job_client.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
"# Create authentication object for user permissions\n",
2727
"# IF unused, SDK will automatically check for default kubeconfig, then in-cluster config\n",
2828
"# KubeConfigFileAuthentication can also be used to specify kubeconfig path manually\n",
29-
"\n",
3029
"auth_token = \"XXXXX\" # The auth_token is used later for the RayJobClient\n",
3130
"auth = TokenAuthentication(\n",
3231
" token = auth_token,\n",
@@ -43,6 +42,7 @@
4342
"outputs": [],
4443
"source": [
4544
"# Create and configure our cluster object\n",
45+
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
4646
"cluster = Cluster(ClusterConfiguration(\n",
4747
" name='jobtest',\n",
4848
" namespace='default', # Update to your namespace\n",

demo-notebooks/guided-demos/0_basic_ray.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"id": "8d4a42f6",
66
"metadata": {},
77
"source": [
8-
"In this first notebook, we will go through the basics of using the SDK to:\n",
8+
"In first notebook, we will go through the basics of using the SDK to:\n",
99
" - Spin up a Ray cluster with our desired resources\n",
1010
" - View the status and specs of our Ray cluster\n",
1111
" - Take down the Ray cluster when finished"
@@ -61,7 +61,7 @@
6161
"outputs": [],
6262
"source": [
6363
"# Create and configure our cluster object\n",
64-
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\"\n",
64+
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
6565
"cluster = Cluster(ClusterConfiguration(\n",
6666
" name='raytest',\n",
6767
" namespace='default', # Update to your namespace\n",

demo-notebooks/guided-demos/1_basic_instascale.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"id": "9865ee8c",
66
"metadata": {},
77
"source": [
8-
"In this second notebook, we will go over the basics of using InstaScale to scale up/down necessary resources that are not currently available on your OpenShift Cluster (in cloud environments).\n",
8+
"In this notebook, we will go over the basics of using InstaScale to scale up/down necessary resources that are not currently available on your OpenShift Cluster (in cloud environments).\n",
99
"\n",
1010
"NOTE: The InstaScale and MCAD components are in Tech Preview"
1111
]

demo-notebooks/guided-demos/2_cluster_job_client.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"cell_type": "markdown",
55
"metadata": {},
66
"source": [
7-
"In this third demo we will go over the basics of the Ray Job Submission Client in the SDK"
7+
"In this demo we will go over the basics of the Ray Job Submission Client in the SDK"
88
]
99
},
1010
{
@@ -26,7 +26,6 @@
2626
"# Create authentication object for user permissions\n",
2727
"# IF unused, SDK will automatically check for default kubeconfig, then in-cluster config\n",
2828
"# KubeConfigFileAuthentication can also be used to specify kubeconfig path manually\n",
29-
"\n",
3029
"auth = TokenAuthentication(\n",
3130
" token = \"XXXXX\",\n",
3231
" server = \"XXXXX\",\n",
@@ -42,6 +41,7 @@
4241
"outputs": [],
4342
"source": [
4443
"# Create and configure our cluster object\n",
44+
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
4545
"cluster = Cluster(ClusterConfiguration(\n",
4646
" name='jobtest',\n",
4747
" namespace='default', # Update to your namespace\n",

demo-notebooks/guided-demos/3_basic_interactive.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"id": "bbc21043",
66
"metadata": {},
77
"source": [
8-
"In this fourth notebook, we will go over how to leverage the SDK to directly work interactively with a Ray Cluster during development."
8+
"In this notebook, we will go over how to leverage the SDK to directly work interactively with a Ray Cluster during development."
99
]
1010
},
1111
{
@@ -58,7 +58,7 @@
5858
"outputs": [],
5959
"source": [
6060
"# Create and configure our cluster object\n",
61-
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\"\n",
61+
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
6262
"namespace = \"default\" # Update to your namespace\n",
6363
"cluster_name = \"interactivetest\"\n",
6464
"cluster = Cluster(ClusterConfiguration(\n",
@@ -136,7 +136,7 @@
136136
"outputs": [],
137137
"source": [
138138
"from codeflare_sdk import generate_cert\n",
139-
"# Export the environment variables to enable TLS\n",
139+
"# Create required TLS cert and export the environment variables to enable TLS\n",
140140
"generate_cert.generate_tls_cert(cluster_name, namespace)\n",
141141
"generate_cert.export_env(cluster_name, namespace)"
142142
]

demo-notebooks/guided-demos/notebook-ex-outputs/0_basic_ray.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"id": "8d4a42f6",
66
"metadata": {},
77
"source": [
8-
"In this first notebook, we will go through the basics of using the SDK to:\n",
8+
"In this notebook, we will go through the basics of using the SDK to:\n",
99
" - Spin up a Ray cluster with our desired resources\n",
1010
" - View the status and specs of our Ray cluster\n",
1111
" - Take down the Ray cluster when finished"
@@ -69,7 +69,7 @@
6969
],
7070
"source": [
7171
"# Create and configure our cluster object\n",
72-
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\"\n",
72+
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
7373
"cluster = Cluster(ClusterConfiguration(\n",
7474
" name='raytest',\n",
7575
" namespace='default', # Update to your namespace\n",

demo-notebooks/guided-demos/notebook-ex-outputs/1_basic_instascale.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"id": "9865ee8c",
66
"metadata": {},
77
"source": [
8-
"In this second notebook, we will go over the basics of using InstaScale to scale up/down necessary resources that are not currently available on your OpenShift Cluster (in cloud environments).\n",
8+
"In this notebook, we will go over the basics of using InstaScale to scale up/down necessary resources that are not currently available on your OpenShift Cluster (in cloud environments).\n",
99
"\n",
1010
"NOTE: The InstaScale and MCAD components are in Tech Preview"
1111
]

demo-notebooks/guided-demos/notebook-ex-outputs/2_cluster_job_client.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"cell_type": "markdown",
55
"metadata": {},
66
"source": [
7-
"In this third demo we will go over the basics of the Ray Job Submission Client in the SDK"
7+
"In this demo we will go over the basics of the Ray Job Submission Client in the SDK"
88
]
99
},
1010
{
@@ -26,7 +26,6 @@
2626
"# Create authentication object for user permissions\n",
2727
"# IF unused, SDK will automatically check for default kubeconfig, then in-cluster config\n",
2828
"# KubeConfigFileAuthentication can also be used to specify kubeconfig path manually\n",
29-
"\n",
3029
"auth = TokenAuthentication(\n",
3130
" token = \"XXXXX\",\n",
3231
" server = \"XXXXX\",\n",
@@ -42,6 +41,7 @@
4241
"outputs": [],
4342
"source": [
4443
"# Create and configure our cluster object\n",
44+
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
4545
"cluster = Cluster(ClusterConfiguration(\n",
4646
" name='jobtest',\n",
4747
" namespace='default', # Update to your namespace\n",

0 commit comments

Comments
 (0)