Skip to content

Commit 93c1a40

Browse files
yuanchi2807GitHub Enterprise
authored andcommitted
Merge branch 'develop' into pipeline_terminal_bug
2 parents daaca0d + 14c53e4 commit 93c1a40

File tree

5 files changed

+32
-4
lines changed

5 files changed

+32
-4
lines changed

.github/pull_request_template.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
**Related Issue**
2+
3+
<!-- List any issues that this pr is related to, fixes or supports -->
4+
5+
Supports #ISSUE_NUMBER
6+
7+
**Related PRs**
8+
9+
<!-- Does this pr depend on or replace an existing pr? Link it here -->
10+
11+
This PR is not dependent on any other PR
12+
13+
**What does this PR do?**
14+
15+
<!-- The intent of this section is to help team members understand the scope of your changes and why you are making said changes. If there are any concerns or risks associated with your pull request, they should be documented here so your team members can give informative feedback in their reviews. -->
16+
17+
**Description of Changes**
18+
19+
<!-- The intent of this section is to describe the implementation details of the changes you made. Any architectural decisions made should be noted here as well as a short description of why you made that decision. -->
20+
21+
**What gif most accurately describes how I feel towards this PR?**
22+
23+
<!-- Cute animals are also acceptable. -->
24+
25+
![Example of a gif](https://media.github.ibm.com/user/59/files/074da280-78ba-11ea-81d1-49ce0654c29d)

codeflare/pipelines/Datamodel.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import ray
99
import codeflare.pipelines.Exceptions as pe
1010

11-
1211
class Xy:
1312
"""
1413
Holder class for Xy, where X is array-like and y is array-like. This is the base
@@ -94,6 +93,7 @@ class Node(ABC):
9493
The hash code of this node is the name of the node and equality is defined if the
9594
node name and the type of the node match.
9695
"""
96+
9797
def __init__(self, node_name, node_input_type: NodeInputType, node_firing_type: NodeFiringType, node_state_type: NodeStateType):
9898
self.__node_name__ = node_name
9999
self.__node_input_type__ = node_input_type
@@ -151,6 +151,7 @@ def __init__(self, node_name: str, estimator: BaseEstimator):
151151
:param node_name: Name of the node
152152
:param estimator: The base estimator
153153
"""
154+
154155
super().__init__(node_name, NodeInputType.OR, NodeFiringType.ANY, NodeStateType.IMMUTABLE)
155156
self.__estimator__ = estimator
156157

codeflare/pipelines/Runtime.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ def execute_or_node_remote(node: dm.EstimatorNode, mode: ExecutionType, xy_ref:
5353
else:
5454
res_Xref = ray.put(estimator.transform(X))
5555
result = dm.XYRef(res_Xref, xy_ref.get_yref())
56+
5657
return result
5758
elif mode == ExecutionType.PREDICT:
5859
# Test mode does not clone as it is a simple predict or transform

notebooks/Ray graph experiments.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@
137137
},
138138
{
139139
"cell_type": "code",
140-
"execution_count": 9,
140+
"execution_count": 34,
141141
"id": "uniform-coordinator",
142142
"metadata": {},
143143
"outputs": [],
@@ -160,7 +160,7 @@
160160
},
161161
{
162162
"cell_type": "code",
163-
"execution_count": 11,
163+
"execution_count": 36,
164164
"id": "handy-offset",
165165
"metadata": {},
166166
"outputs": [],

requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
ray~=1.3.0
22
setuptools~=52.0.0
33
sklearn~=0.0
4-
scikit-learn~=0.24.1
4+
scikit-learn~=0.24.1
5+
pandas~=1.2.4

0 commit comments

Comments
 (0)