Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ellipses to truncate long constraint values at responsive breakpoints #1006

Merged
merged 1 commit into from
Nov 12, 2014

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Nov 10, 2014

Fixes #925, maybe, @jronallo?

@jkeck, I saw we were truncating values in searchworks. Do you think these values are close enough to searchworks, or could they use some tweaking?

For reference:

// Extra small screen / phone
$screen-xs:                  480px !default;
$screen-sm:                  768px !default;
$screen-md:                  992px !default;
$screen-lg:                  1200px !default;

screen shot 2014-11-10 at 2 34 23 pm
screen shot 2014-11-10 at 2 34 40 pm
screen shot 2014-11-10 at 2 34 28 pm
screen shot 2014-11-10 at 2 34 35 pm

@jkeck
Copy link
Contributor

jkeck commented Nov 10, 2014

@cbeer I think we're doing truncation that is not necessarily tied to breakpoints (should theoretically work under any viewport size) so we should be fine with this.

@jcoyne
Copy link
Member

jcoyne commented Nov 11, 2014

Looks 👌 to me.

@cbeer cbeer modified the milestone: 5.8.0 Nov 11, 2014
@cbeer
Copy link
Member Author

cbeer commented Nov 12, 2014

Oh, and I should add: there's a mouse-over title with the untruncated value.

cbeer added a commit that referenced this pull request Nov 12, 2014
Use ellipses to truncate long constraint values at responsive breakpoints
@cbeer cbeer merged commit a8fd122 into master Nov 12, 2014
@cbeer cbeer deleted the constraint-breakpoints branch November 12, 2014 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

long filterValue with nowrap exceeds device width causing side scrolling
3 participants