Provided better errors when components are mis-configured #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behavior is permissive, and works without warnings. This change makes it so that omitting the LocalizationProvider throws an error. I was originally trying to decide between throwing an error and emitting a console error. I opted for an error to have the behavior in line with what the react-redux Provider does. This is potentially a breaking change for users that are relying on the LocalizationProvider being omitted before the bundles are loaded. This behavior can still be achieved by providing an empty bundle list to the LocalizationProvider.
gregtatum
commented
Apr 12, 2021
gregtatum
commented
Apr 12, 2021
gregtatum
commented
Apr 12, 2021
gregtatum
commented
Apr 12, 2021
gregtatum
commented
Apr 12, 2021
gregtatum
commented
Apr 12, 2021
dminor
approved these changes
Apr 16, 2021
zbraniecki
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit here is well-ordered and can be considered separately.
Resolves #519.
The second commit isn't particularly risky, but the first introduces a new
throwfor misconfigured systems. See the commit message for more information.dminor: As we discussed in Slack it would be great if you could look over the code. It's using TypeScript.
zibi: I also added you on here as a reviewer, as Dan wanted someone with JS experience to also look over it. Feel free to redirect if you know someone better to look at it.