Skip to content

Updated for fluent.syntax 0.14+ / Fluent spec 1.0 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2019
Merged

Updated for fluent.syntax 0.14+ / Fluent spec 1.0 #116

merged 1 commit into from
May 11, 2019

Conversation

spookylukey
Copy link
Collaborator

No description provided.

@spookylukey spookylukey requested a review from Pike May 4, 2019 05:55
Pike
Pike suggested changes May 8, 2019
View reviewed changes
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this. As you probably heard in the news, I was busy :-/ This looks good overall.

I found something that I think is a bug, and I don't find the tests from the js side of things, so maybe that's an actual bug?

@spookylukey spookylukey merged commit e2cfea0 into projectfluent:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Pike Pike Pike approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spookylukey @Pike