Improve keyboard handling #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resume: start now a clone of the selected activity.
Ctrl-+: clone or fallback to new if none selected.
(same as pressing the + button)
Ctrl-R: only Resume (clone) an existing fact.
Ctrl-N: only new.
For consistency (only do something if it makes sense), and early bug catching, let delete_row(fact) eventually raise exception downstream if fact is None.
- move elif to match the correct if (indentation) - forward also KEY_Home, KEY_End, and KEY_Delete
Closed
|
Nice! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcuts (#230)
Arrows to navigate between dates and facts.
checks
The following are tests, and show potential uses.
Left/Right arrow: change dates
With nothing selected
Ctrl-R: do nothing
Ctrl-N: new empty fact
Ctrl-+: new empty fact
Ctrl-Enter or Enter: do nothing
Select one fact
Ctrl-R clone, starting now
Ctrl-N new empty fact
Ctrl-+ clone, starting now
Ctrl-Enter or Enter: edit selected fact
Create a new fact
if not selected
Delete: do nothing
select the fact
Delete: fact deleted
With enough dates to have more facts than can fit in the overview,
to check scrolling,
check that the following keys work also right at the start of overview,
(without having to focus on the FactTree itself)
Up, Down,
Home, End (change selected fact)
Page up, Page down, (just scroll)
With an ongoing fact
Ctrl+Space: stop