Added #current_version? to Rubydora::Datastream #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
If versioning isn't enabled, versions may be an empty array (and so, should return true)
Contributor
Author
|
@cbeer I added the condition to the method, but I can't reproduce the scenario in which versions is empty for a persisted datastream (i.e., new? is false). I tried creating an ActiveFedora model with a non-versionable datastream, but it always has one version after saving. |
Contributor
|
Ok, I may be wrong about the fcrepo3 API. |
Contributor
Author
|
I'm OK leaving it in, if it has any future value. Let me know if I should amend the PR. |
Contributor
|
+1, thanks (partly because fcrepo4 doesn't have versioning yet). |
Contributor
Author
|
So, two commits are OK? Or did you want me to rebase? |
jeremyf
added a commit
that referenced
this pull request
May 20, 2013
Added #current_version? to Rubydora::Datastream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on hydra-tech.