-
Notifications
You must be signed in to change notification settings - Fork 797
Prepare release 0.18.0
#1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 0.18.0
#1196
Conversation
* [FEATURE] Add `stat_progress_vacuum` collector by @ianbibby * [FEATURE] Add `buffercache_summary` collector by @sfc-gh-pnuttall * [FEATURE] `stat_statements`: export query itself together with `queryId` by @Delorien84 * [ENHANCEMENT] Update Go version by @SuperQ * [ENHANCEMENT] Improve error handling for `Server.Scrape` by @BoweFlex * [ENHANCEMENT] `stat_user_tables`: record table-only size bytes in addition to the total size bytes by @Sticksman * [ENHANCEMENT] (chore) Fix a typo and use `slices.Contains` by @cristiangreco * [ENHANCEMENT] Update mixin to latest changes from `grafana/postgres_exporter` by @cristiangreco, @gaantunes, @v-zhuravlev and @mshahzeb * [ENHANCEMENT] Exclude the metrics fetching session's data from pg_stat_activity by @kmoppel * [BUGFIX] Ensure database connections are always closed by @cristiangreco and @dehaansa Signed-off-by: Cristian Greco <cristian@regolo.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we release a version, I think we need to look into this - seems like others have found this to be a bug #1185 (review)
Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Cristian Greco <cristian@regolo.cc>
That PR is merged and included in the changelog. Do you mean that there's a bug introduced by that PR? Or that we should scan the code to find other cases like that? |
Sorry, I should have been more explicit. I believe that #1185 fixed a problem, however introduced a new bug. There is a reference to that PR from planetscale's repo where they reverted it. planetscale#7 Taking a closer look, the problem is a semicolon in the middle of the query. I just opened #1197 to fix it. I can't believe I missed that on the first review. |
7e0ccff
to
64a77bc
Compare
Signed-off-by: Cristian Greco <cristian@regolo.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0.18.0 / 2025-09-25
stat_progress_vacuum
collector by @ianbibby in Adds pg_stat_progress_vacuum collector #1141buffercache_summary
collector by @sfc-gh-pnuttall in Add a collector forpg_buffercache_summary
. #1165stat_statements
: export query itself together withqueryId
by @Delorien84 in Export query itself together with queryId in stat_statement metrics #940Server.Scrape
by @BoweFlex in Feat: Improve Error Handling for Server.Scrape #1158stat_user_tables
: record table-only size bytes in addition to the total size bytes by @Sticksman Sticksman in Record table only size bytes as well in addition to the total size bytes #1149slices.Contains
by @cristiangreco in chore: fix a typo and useslices.Contains
#1176grafana/postgres_exporter
by @cristiangreco, @gaantunes, @v-zhuravlev and @mshahzeb in Update mixin to latest changes from grafana/postgres_exporter #1179process_idle
by @sysadmind in Fix #1185 bug #1197