Fix #1185 bug #1197
Merged
Fix #1185 bug #1197
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This semicolon breaks the query Signed-off-by: Joe Adams <github@joeadams.io>
Merged
SuperQ
approved these changes
Sep 24, 2025
cristiangreco
approved these changes
Sep 24, 2025
|
@sysadmind @SuperQ are we good merging this? I could go ahead with #1196 then if you're ok |
|
It's very unfortunate that the tests didn't catch it. I think we need to take a look at how we do testing in this project and see if we can improve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This semicolon breaks the query
/cc @kmoppel