Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported Go version (1.17) #1062

Merged
merged 1 commit into from Jun 5, 2022
Merged

Update minimum supported Go version (1.17) #1062

merged 1 commit into from Jun 5, 2022

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Jun 3, 2022

Update minimum supported Go to 1.17 to support new module format.

Signed-off-by: SuperQ superq@gmail.com

Update minimum supported Go to 1.17 to support new module format.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ requested review from kakkoyun and bwplotka Jun 3, 2022
@kakkoyun
Copy link
Member

kakkoyun commented Jun 3, 2022

@SuperQ Even though, you removed the 1.16, I think it still waits for that check to pass. Because of that, I can't merge it. Any ideas? Or feel free to merge it using your admin rights.

@SuperQ
Copy link
Member Author

SuperQ commented Jun 5, 2022

I updated the branch protection rules to remove the 1.16 required test.

@SuperQ SuperQ merged commit e38d614 into main Jun 5, 2022
7 checks passed
@SuperQ SuperQ deleted the superq/bump_go branch Jun 5, 2022
@kakkoyun kakkoyun changed the title Update minimum supported Go version Update minimum supported Go version (1.17) Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants