Update exporters.md - Added hostadp exporter #1317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brazil
reviewed
Apr 1, 2019
There was a problem hiding this comment.
Some things to help you improve this exporter:
Units should be included in metric name.
Seconds are the standard units for time.
The _info suffix should be used for Info metrics, the current uses are normal gauges.
You shouldn't need to shell out to ls/grep/awk, you can use os.listdir.
Signed-off-by: Miguel Catalan <miguel.catalan@i2cat.net>
brian-brazil
pushed a commit
that referenced
this pull request
Apr 9, 2019
Add hostapd exporter to the list of Miscellaneous related exporters. This exporter monitors statistics of the Wi-Fi Access Points managed by the hostapd software. Code updated according to #1317 (review) Signed-off-by: Catalan, Miguel <miguel.catalan@i2cat.net>
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
…theus#1315)" (prometheus#1316)" (prometheus#1317) This reverts commit 911e760.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hostapd exporter to the list of Hardware related exporters. This exporter monitors statistics of the Wi-Fi Access Points managed by the hostapd software.