Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exporter for KDB+ #1626

Merged
merged 2 commits into from
May 25, 2020
Merged

Add exporter for KDB+ #1626

merged 2 commits into from
May 25, 2020

Conversation

sshanks-kx
Copy link
Contributor

Add exporter for KDB+

Ref:
https://github.com/KxSystems/prometheus-kdb-exporter
https://kx.com/

Signed-off-by: Simon Shanks sshanks@kx.com

@sshanks-kx
Add exporter for KDB+
cb369a5 
Signed-off-by: Simon Shanks <sshanks@kx.com>
@sshanks-kx sshanks-kx mentioned this pull request May 12, 2020
Closed
@brian-brazil
Copy link
Contributor

A few comments to help improve the exporter:

Gauges should not end in _total. summary and histogram should not be part of metric names - and there's no need to expose both for the same data, just a histogram will do. The memory metrics sound kdb specific rather than the process_ metrics coming from a client library, so should be prefixed with kdb_.
memory_physical_bytes is a machine-level metric, and the node exporter should be relied upon for that.
You should seem to be setting the http content-type.

brian-brazil
brian-brazil reviewed May 12, 2020
View reviewed changes
content/docs/instrumenting/exporters.md Outdated
@@ -38,6 +38,7 @@ wide variety of JVM-based applications, for example [Kafka](http://kafka.apache.
* [Druid Exporter](https://github.com/opstree/druid-exporter)
* [ElasticSearch exporter](https://github.com/justwatchcom/elasticsearch_exporter)
* [EventStore exporter](https://github.com/marcinbudny/eventstore_exporter)
* [KDB+ exporter](https://github.com/KxSystems/prometheus-kdb-exporter) (**official**)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an official exporter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does official mean that its an official exporter that's from Prometheus, or the official exporter from the product that's it is to be used with?
I had interpreted that its official if its created by the company upon which its used.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just noticed on the page it had
'Some of these exporters are maintained as part of the official Prometheus GitHub organization, those are marked as official, others are externally contributed and maintained.'
Will change it.

@sshanks-kx
Removed 'official' from exporter
12a1c9e 
Signed-off-by: Simon Shanks <sshanks@kx.com>
@brian-brazil
Copy link
Contributor

Can you fix the DCO? Squashing is usually easiest.

@brian-brazil brian-brazil merged commit 08f6c6f into prometheus:master May 25, 2020
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-brazil brian-brazil brian-brazil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshanks-kx @brian-brazil