-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Various native histogram spec updates #2752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Neither +Inf nor NaN are valid custom values. Signed-off-by: beorn7 <beorn@grafana.com>
We originally planned to not include this in the initial feature set. But now prometheus/prometheus#17278 is underway, so let's aim for it. Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
We are currently not really implementing this, but we should. It's just a minor issue, but see prometheus/prometheus#17308 to get it right. Signed-off-by: beorn7 <beorn@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the parts related to NHCB custom values (validation, reconciling).
I'm not familiar enough with counter reset hints, someone else should review that part.
Related question: it is not very clear from the spec, whether Also the spec should state that |
Right, we should make the handling of -Inf explicit (as we do for the standard exponential schemas). |
Signed-off-by: beorn7 <beorn@grafana.com>
I added a commit for that. WRT -Inf as the 1st custom value: I think it should be allowed. That's implicit from the spec. I don't think we have to make it explicit in the spec. Just fix the Validate method. (Will create a PR momentarily.) |
See commit descriptions for details.
Let's only merge this once we are positive about how and when to tackle the related issues:
FYI: