Two minor docs improvements. #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2015 13:02
| * <code><b>processor</b>\_requests\_total</code> | ||
| * must have a single unit (i.e. do not mix seconds with milliseconds) | ||
| * should have a units suffix | ||
| * ...should have a (single-word) application prefix relevant to the domain the metric belongs to. The prefix is sometimes referred to as `namespace` by client libraries. For metrics specific to an application, the prefix is usually the application name itself. Sometimes, however, metrics are more generic, like standardized metrics exported by client libraries. Examples: |
There was a problem hiding this comment.
I think you should be able to wrap this text, even if it's in a list (indent everything by two spaces?)?
beorn7
force-pushed
the
beorn7/doc-improve
branch
from
66cc246 to
745ac28
Compare
beorn7
pushed a commit
that referenced
this pull request
May 29, 2015
This should have been part of #95, but somehow I missed to commit it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@juliusv @fabxc