Add gitlab runner to Software exposing Prometheus metrics #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add gitlab runner in Software exposing Prometheus metrics
oussemos
changed the title
|
https://gitlab.com/gitlab-org/gitlab-runner/blob/master/executors/docker/machine/provider.go#L431 Most of this seems to be custom collectors, this is the only direct instrumentation I can find and it is procedurally generating metric names which is a no-no. That should be a label. My idea is that directly instrumented code listed here provides prime examples of what Prometheus instrumentation is meant to look like. |
|
@brian-brazil Thanks for noticing this. We're currently in the process of cleaning-up the metrics naming in GitLab Runner, see https://gitlab.com/gitlab-org/gitlab-runner/issues/3114. |
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
* Update TOC.md * Delete character-set-configuration.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gitlab runner in Software exposing Prometheus metrics