Disable workaround for ipython >= 8.18 #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornaria
force-pushed
the
ipython-workaround
branch
from
372101c to
b3c2b3c
Compare
tornaria
force-pushed
the
ipython-workaround
branch
from
b3c2b3c to
55a45b1
Compare
tornaria
added a commit
to tornaria/void-packages
that referenced
this pull request
Dec 1, 2023
tornaria
added a commit
to tornaria/void-packages
that referenced
this pull request
Dec 1, 2023
ahesford
pushed a commit
to void-linux/void-packages
that referenced
this pull request
Dec 1, 2023
jason1987d
pushed a commit
to jason1987d/void-packages
that referenced
this pull request
Dec 8, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ipython 8.18 already merged ipython/ipython#14241, this workaround is no longer necessary. Moreover, the workaround gives a deprecation warning in python 3.12.
This PR uses the test
sys.modules['IPython'].version_info < (8, 18, 0, '')to apply the workaround only in older ipython.In case the IPython module is not loaded this will
raiseKeyErrorand correctlyreturn Falsethanks to theexcept BaseException` already there.See: #1811 (comment)
Cc: @jonathanslenders