Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exif.js to attempt to place images #67

Closed
jywarren opened this issue Jan 31, 2015 · 3 comments
Closed

Use exif.js to attempt to place images #67

jywarren opened this issue Jan 31, 2015 · 3 comments

Comments

@jywarren
Copy link
Member

Code for this may already exist in Vidun's work, but I'm not sure if it uses exif.js -- the new Mapmill does, however: https://github.com/publiclab/mapmill

This is partially working; sandbox it here: http://mapknitter.org/maps/exif-test

@jywarren jywarren changed the title Use Exit.js to attempt to place images Use exif.js to attempt to place images Feb 3, 2015
@jywarren jywarren modified the milestone: 2.1 release Feb 25, 2015
@jywarren
Copy link
Member Author

jywarren commented Mar 6, 2015

This is largely working now! Much refactoring and now pushing to production!!!

@jywarren
Copy link
Member Author

jywarren commented Mar 6, 2015

Still would like to enable rotation and altitude scaling, and ALSO we need to change the scale of the image so that if it's placed at the wrong zoom level, it doesn't attempt to place an image across all of north america. Maybe a quick fix would be a default zoom before initiating -- only if we're too zoomed out?

@vidhunv1
Copy link
Contributor

vidhunv1 commented Mar 7, 2015

Hi everyone,

Sorry for being out of touch lately, have been busy with semesters.

I realised that GPS placement is working only for lat/long placements in
MapKnitter 2, the summer work took care of most of the features mentioned.
I think what you mentioned above was already taken care of, if you are at a
wrong zoom level and you attempt to place an image, the image would still
get placed with the correct scale only if your zoom is too far off you
wouldn't be able to see your image unless zoomed to the correct level.

Please do ping me if anything is required from my end.

Thanks.

On Sat, Mar 7, 2015 at 5:09 AM, Jeffrey Warren notifications@github.com
wrote:

Still would like to enable rotation and altitude scaling, and ALSO we need
to change the scale of the image so that if it's placed at the wrong zoom
level, it doesn't attempt to place an image across all of north america.
Maybe a quick fix would be a default zoom before initiating -- only if
we're too zoomed out?


Reply to this email directly or view it on GitHub
#67 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants