fully externalize exporter; untested #530
Conversation
|
Hmm, the second failure is: I wonder if this has to do with the change in |
| @@ -1,3 +1,5 @@ | |||
| require "mapknitterExporter" | |||
There was a problem hiding this comment.
Hmm, @icarito i'm seeing File does not exist: mapknitterExporter from this. I copied the Sinatra app config... any ideas?
|
Hi @sashadev-sky -- note that this might touch your work on tracking external status... just FYI! |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| def generate_perspectival_distort(pxperm, path) | ||
| Exporter.generate_perspectival_distort(pxperm, path, nodes_array, id, image_file_name, image, height, width) | ||
| MapKnitterExporter.generate_perspectival_distort(pxperm, path, nodes_array, image_file_name, image.url(:original), height, width, Rails.root) |
| @@ -1,3 +1,5 @@ | |||
| require "mapknitterExporter" | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -37,6 +37,8 @@ group :dependencies do | |||
| gem "autoprefixer-rails" | |||
| gem "uglifier" | |||
|
|
|||
| # switch to main version once ready: | |||
| gem "mapknitter-exporter", git: 'https://github.com/publiclab/mapknitter-exporter', glob: '*.gemspec' | |||
| @@ -37,6 +37,8 @@ group :dependencies do | |||
| gem "autoprefixer-rails" | |||
| gem "uglifier" | |||
|
|
|||
| # switch to main version once ready: | |||
| gem "mapknitter-exporter", git: 'https://github.com/publiclab/mapknitter-exporter', glob: '*.gemspec' | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
Code Climate has analyzed commit 62daf27 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
@jywarren noted! |
could this be carried over from the potential problem we were discussing in this PR? #341 |
|
hey @jywarren @sashadev-sky, anything you want to update on this PR? |
|
@gauravano good catch! Not sure, a @jywarren will have to advise! |
|
So, I think actually we'll be going directly to the Cloud exporter in #693, so we'll get that working fully with a UI, then start stripping out the exporter code from this project entirely! cc @ViditChitkara @divyabaid16 |
Integrating work from publiclab/mapknitter-exporter#5 to get all Ruby/Gdal/ImageMagick exporting code out of the core app!