Feature inline grid.js

[Divine-peace]

Changed from var to let

Fixes #11487

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

[codeclimate]

Analysis results are not available for those commits

View more on Code Climate.

[TildaDares]

Hi @Divine-peace, your PR contains commits from other contributors. Please amend this. Thank you!

[Divine-peace]

Okay thanks

…

On Wed, Oct 19, 2022, 12:23 PM Tilda Udufo ***@***.***> wrote: ***@***.**** requested changes on this pull request. Hi @Divine-peace <https://github.com/Divine-peace>, your PR contains commits from other contributors. Please amend this. Thank you! — Reply to this email directly, view it on GitHub <#11511 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYUXTBVST53677QUSTM44DTWD7KZNANCNFSM6AAAAAARIGXMOE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[TildaDares]

Hi @Divine-peace, could you close this PR and open a new one? Make sure you pull in the recent changes, create a new branch and then add your changes. Thank you!

[Divine-peace]

Okay

…

On Fri, Oct 21, 2022, 12:22 PM Tilda Udufo ***@***.***> wrote: Hi @Divine-peace <https://github.com/Divine-peace>, could you close this PR and open a new one? Make sure you pull in the recent changes, create a new branch and then add your changes. Thank you! — Reply to this email directly, view it on GitHub <#11511 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYUXTBQIHNYNY7ELEIP4KZ3WEJ4HHANCNFSM6AAAAAARIGXMOE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[TildaDares]

Hi @Divine-peace, do you need help with this?

[Divine-peace]

Yes

…

On Tue, Oct 25, 2022, 7:30 AM Tilda Udufo ***@***.***> wrote: Hi @Divine-peace <https://github.com/Divine-peace>, do you need help with this? — Reply to this email directly, view it on GitHub <#11511 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYUXTBSTITWZVSKZM2LYMNTWE55ADANCNFSM6AAAAAARIGXMOE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[TildaDares]

You can edit the file directly from the web by using this link https://github.com/publiclab/plots2/edit/main/spec/javascripts/inline_grids_spec.js. You can follow this guide if you get stuck https://docs.github.com/en/repositories/working-with-files/managing-files/editing-files#editing-files-in-another-users-repository

[Divine-peace]

Thanks so much

…

On Tue, Oct 25, 2022, 6:20 PM Tilda Udufo ***@***.***> wrote: You can edit the file directly from the web by using this link https://github.com/publiclab/plots2/edit/main/spec/javascripts/inline_grids_spec.js. You can follow this guide if you get stuck https://docs.github.com/en/repositories/working-with-files/managing-files/editing-files#editing-files-in-another-users-repository — Reply to this email directly, view it on GitHub <#11511 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYUXTBRTPHM75NSNDFFMUILWFAJERANCNFSM6AAAAAARIGXMOE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[TildaDares]

Resolved in #11552