Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes test for sets/embed2/:id #741

Closed
5 tasks
Tlazypanda opened this issue Oct 7, 2021 · 7 comments · Fixed by #799
Closed
5 tasks

Add routes test for sets/embed2/:id #741

Tlazypanda opened this issue Oct 7, 2021 · 7 comments · Fixed by #799

Comments

@Tlazypanda
Copy link
Collaborator

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file routes_test.rb in the spectral-workbench repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in read (and a -) which lines to remove, and in green (and a +) which lines to add:

+  test "test get request for sets embed2" do
+    assert_routing({ path: '/sets/embed2/:id', method: 'get' }, {controller: 'sets', action: 'embed2', id: ':id' })
+  end
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@Onyinye91-ctrl
Copy link

@Tlazypanda Can i work on this?

@paulinagadea
Copy link

Done! #746

@madhhuurrii
Copy link

Hii Is this issue up for grab?

@rhonall
Copy link
Contributor

rhonall commented Dec 3, 2021

Hi, just wondering if this issue is still available, if yes I would like to work on this. Thanks :)

@Tlazypanda
Copy link
Collaborator Author

Go ahead @rhonall ✌️

@Tlazypanda Tlazypanda assigned rhonall and unassigned paulinagadea Dec 3, 2021
@rhonall
Copy link
Contributor

rhonall commented Dec 3, 2021

@Tlazypanda Thanks! I will work on it now :)

@rhonall rhonall mentioned this issue Dec 3, 2021
5 tasks
@rhonall
Copy link
Contributor

rhonall commented Dec 3, 2021

Done #741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants