Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAMsys 5.0] DRAMsys co-simulation with MemPool/TeraPool system #106

Merged
merged 48 commits into from
May 6, 2024

Conversation

yichao-zh
Copy link
Collaborator

@yichao-zh yichao-zh commented Mar 22, 2024

Continuation of #93:

Changelog

  • Add DRAMsys co-simulation supporting

Added

  • Add dram_rtl_sim submodule for off-chip DRAM simulation
  • Add HBM2 DRAM configurations

Changed

  • mempool_tb hardware testbench with DRAM pre-loading function
  • memcpy kernel update with verification
  • mempool_system RTL update for DRAM interconnection
  • Makefile update for building the DRAMsys environment
  • README and CHANGELOG

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

Copy link
Member

@SamuelRiedel SamuelRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yichao. I have a few questions and comments left. Also, just for the final PR, can we squash the commits that added and then removed the complete dram-sys dependency? Otherwise, they will always be in the main tree and add a significant overhead for every clone.

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
config/mempool.mk Show resolved Hide resolved
config/minpool.mk Show resolved Hide resolved
config/terapool.mk Show resolved Hide resolved
hardware/Makefile Show resolved Hide resolved
hardware/src/mempool_cc.sv Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
…igurations, and compiling dramsys dynamic library.
…le will patch to dram_sim_rtl submodule by makefile target
…better DRAM BW as the HBM2 support upto 3600Gbps DDR
@yichao-zh yichao-zh force-pushed the terapool_DRAM_RTL branch 2 times, most recently from 6ab46ef to 92891f6 Compare May 2, 2024 16:53
Copy link
Member

@SamuelRiedel SamuelRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot :)

config/mempool.mk Show resolved Hide resolved
hardware/Makefile Show resolved Hide resolved
@yichao-zh yichao-zh merged commit 9dd79af into main May 6, 2024
58 checks passed
@yichao-zh yichao-zh deleted the terapool_DRAM_RTL branch May 6, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants