Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Test installer as a collection #387

Closed
wants to merge 2 commits into from
Closed

Conversation

mdellweg
Copy link
Member

fixes #7313
https://pulp.plan.io/issues/7313

split from #382 see discussions there!

@pulpbot
Copy link
Member

pulpbot commented Aug 12, 2020

Attached issue: https://pulp.plan.io/issues/7313

@mdellweg mdellweg force-pushed the test_collection branch 2 times, most recently from 643ba31 to c766497 Compare August 17, 2020 15:14
pip install --upgrade pip
pip install tox requests
pip install tox PyYAML requests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did we introduce this dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile needs it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add to the Makefile, make install_test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be installed before calling make, as it is needed to compile the targets.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, please just add a comment about why it's needed, since it would not be obvious to an ansible developer.

roles/pulp_common/tasks/install_pip.yml Show resolved Hide resolved
playbooks/example-use/playbook.yml Show resolved Hide resolved
@mdellweg mdellweg mentioned this pull request Aug 20, 2020
@mdellweg mdellweg force-pushed the test_collection branch 2 times, most recently from 1c85b7c to e90e2c8 Compare August 25, 2020 14:12
@mdellweg
Copy link
Member Author

There is one thing about this whole keep the role running standalone that i don't see any proper solution for.
The moment we add nifty plugins like #382 or #372 they will need to be addressed with their FQCN. And that will make the roles incapable of breathing "outside" of the collection. And this is not an ansible 2.8 limitation.

Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the 1 comment, but I am approving this now.

@mdellweg
Copy link
Member Author

mdellweg commented Sep 9, 2020

What kind of bad Karma is this?
Every time i make one of those requested changes, the CI is broken in a new creative way.

Comment on lines +12 to +13
- pulp.pulp_installer.pulp_all_services
- pulp.pulp_installer.pulp_devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned that instead of doing fqdn, we can do:

Suggested change
- pulp.pulp_installer.pulp_all_services
- pulp.pulp_installer.pulp_devel
collections:
- pulp.pulp_installer
roles:
- pulp_all_services
- pulp_devel

I did it in a hack-ish way here:
https://github.com/pulp/pulp_installer/runs/2175295306?check_suite_focus=true
#562

@mikedep333
Copy link
Member

@mdellweg Should we close this?

Do we even still need it? I know that running the collection is an official part of the installer now.

@mdellweg mdellweg closed this Sep 29, 2021
@mdellweg mdellweg deleted the test_collection branch September 29, 2021 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants