-
Notifications
You must be signed in to change notification settings - Fork 81
Conversation
Attached issue: https://pulp.plan.io/issues/7313 |
643ba31
to
c766497
Compare
.github/workflows/pull_request.yaml
Outdated
pip install --upgrade pip | ||
pip install tox requests | ||
pip install tox PyYAML requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did we introduce this dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Makefile needs it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should add to the Makefile, make install_test
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be installed before calling make, as it is needed to compile the targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, please just add a comment about why it's needed, since it would not be obvious to an ansible developer.
1c85b7c
to
e90e2c8
Compare
There is one thing about this whole keep the role running standalone that i don't see any proper solution for. |
e90e2c8
to
55fb77b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the 1 comment, but I am approving this now.
55fb77b
to
c9fd8b3
Compare
What kind of bad Karma is this? |
36aa103
to
2329a4b
Compare
2329a4b
to
90c4808
Compare
90c4808
to
1e77861
Compare
- pulp.pulp_installer.pulp_all_services | ||
- pulp.pulp_installer.pulp_devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned that instead of doing fqdn, we can do:
- pulp.pulp_installer.pulp_all_services | |
- pulp.pulp_installer.pulp_devel | |
collections: | |
- pulp.pulp_installer | |
roles: | |
- pulp_all_services | |
- pulp_devel |
I did it in a hack-ish way here:
https://github.com/pulp/pulp_installer/runs/2175295306?check_suite_focus=true
#562
@mdellweg Should we close this? Do we even still need it? I know that running the collection is an official part of the installer now. |
fixes #7313
https://pulp.plan.io/issues/7313
split from #382 see discussions there!