Add Pulumi OIDC token type availability by Pulumi edition

[meagancojocar]

This PR clarifies which OIDC token types (personal, organization, team) are available for each Pulumi edition.

Changes:

• Added "Token types by edition" section to main OIDC client page
• Updated GitHub, GKE, and EKS OIDC guides with info notes linking to token types
• Clarified that examples show specific token types but others may be available

Fixes #16019

Generated with Claude Code

[claude]

Pull Request Review

Thank you for this helpful addition clarifying OIDC token type availability by edition. The changes are generally well-structured and correctly positioned. I've identified a few issues that need to be addressed:

Issues Found

1. Inconsistent parameter names in documentation

Lines: kubernetes-eks.md:23, kubernetes-gke.md:22

The info notes refer to requested_token_type parameter, but the actual code examples and documentation use requested-token-type (with hyphens, not underscores). This inconsistency could confuse users.

• kubernetes-eks.md:23: "...adjusting the token type in the authorization policies and the requested_token_type parameter."
• kubernetes-gke.md:22: "...adjusting the token type in the authorization policies and the requested_token_type parameter."

Both should use requested-token-type to match the actual parameter name used in the Pulumi auth action (as shown in github.md:60).

2. Missing comma in TypeScript code (syntax error)

Line: kubernetes-eks.md:189

spec: {
    serviceAccountName: "pulumi-service-account"  // Missing comma here
    containers: [{

This is a syntax error in the existing code that should be fixed:

serviceAccountName: "pulumi-service-account",

Style Issues

3. Capitalization inconsistency

Line: _index.md:17

"Github" should be "GitHub" (proper capitalization of the product name). This appears in the opening paragraph.

4. Missing file ending newline

Line: github.md:93 (end of file)

The github.md file does not end with a newline character, which violates the repository's absolute prohibition that "New files: Must always end with a newline."

Recommendations

1. Fix the parameter name inconsistencies to use requested-token-type throughout
2. Add the missing comma in the TypeScript syntax (kubernetes-eks.md:189)
3. Capitalize "GitHub" correctly throughout
4. Ensure github.md ends with a newline

The content is accurate and the additions provide valuable clarity for users. Once these issues are resolved, this will be ready to merge.

[glena]

wow

[meagancojocar]

@claude make the changes in the comment review

[claude]

Claude finished @meagancojocar's task —— View job

---

Implementing review changes

• Read modified files to understand current content
• Fix parameter name inconsistencies (requested_token_type → requested-token-type) in kubernetes-eks.md and kubernetes-gke.md
• Fix missing comma in TypeScript code (kubernetes-eks.md:189)
• Fix capitalization ("Github" → "GitHub") in _index.md
• Ensure github.md ends with newline
• Commit and push changes

Summary

All review issues have been successfully addressed:

1. Parameter name consistency: Fixed requested_token_type to requested-token-type in both kubernetes-eks.md:23 and kubernetes-gke.md:22 to match the actual parameter name used in the Pulumi auth action.

2. TypeScript syntax error: Added the missing comma after serviceAccountName: "pulumi-service-account" in kubernetes-eks.md:189.

3. Capitalization: Fixed "Github" to "GitHub" in _index.md:158.

4. File ending: Added missing newline at the end of github.md.

The changes have been committed and pushed to the branch.

---

Job Run • Branch

[pulumi-bot]

Your site preview for commit f93f23c is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16149-f93f23c3.s3-website.us-west-2.amazonaws.com.

[smithrobs]

much wow 😸