Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce area of the square to minimize FitBox onclick #35

Closed
cpicanco opened this issue Aug 31, 2016 · 10 comments
Closed

Reduce area of the square to minimize FitBox onclick #35

cpicanco opened this issue Aug 31, 2016 · 10 comments

Comments

@cpicanco
Copy link
Contributor

Hi, I have a suggestion.

The problem

Because the entire title bar area is being used, the minimize onClick is conflicting with the BringToFront onClick functionality.

Solution 1

Instead of using the entire title bar area, the minimize area onClick could be reduced to the ICON square (square).

Solution 2

Minimize onDoubleClick in the entire title bar. (However, this conflicts with existing standards, double click on the title bar usually means "expand the window to client boundaries" or "reduce the window to the last reduced state".)

@papr
Copy link
Contributor

papr commented Aug 31, 2016

Solution 3

Successful executed BringToFront action consumes the input. Therefore it would only minimize if the menu is already in front.

@cpicanco What do you think?

@cpicanco
Copy link
Contributor Author

Good!

@mkassner
Copy link
Member

Consumption of input would be strange if the window is already fully
visible.

I would try solution 1 and see how that feels.

M

On Wed, Aug 31, 2016 at 6:22 PM, Rafael Picanço notifications@github.com
wrote:

Good!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABXgp5YjPCuHVZ-O-5vX3XzaQb3Ssskgks5qlao0gaJpZM4Jxv6b
.

@cpicanco
Copy link
Contributor Author

cpicanco commented Aug 31, 2016

@mkassner , @papr 's suggestion implies that the consumption of the input must not occur if the window is fully visible.

@mkassner
Copy link
Member

Yes, while thats possible. Its technically cumbersome and I dont think that
it would feel consistent/logical for the user.

On Wed, Aug 31, 2016 at 7:32 PM, Rafael Picanço notifications@github.com
wrote:

@moritz https://github.com/Moritz, @papr https://github.com/papr 's
suggestion implies that the consumption of the input must not occur if the
window is fully visible.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABXgp6r8wSGRlBLhz6pddYTFLIV0qamEks5qlbqvgaJpZM4Jxv6b
.

@cpicanco
Copy link
Contributor Author

Well, suggestion 1 then!

papr added a commit that referenced this issue Sep 1, 2016
@papr
Copy link
Contributor

papr commented Sep 1, 2016

@cpicanco Could you test the PR?

@cpicanco
Copy link
Contributor Author

cpicanco commented Sep 1, 2016

@papr , yep

@cpicanco
Copy link
Contributor Author

cpicanco commented Sep 1, 2016

Functionality is working. However, I think I have found a bug. I checked and it was not introduced by any commit since fd3faf0.

I will create a separated issue for that.

@cpicanco
Copy link
Contributor Author

cpicanco commented Sep 1, 2016

#37

@cpicanco cpicanco changed the title Minimize FitBox onclick Reduce area of the square to minimize FitBox onclick Sep 1, 2016
mkassner added a commit that referenced this issue Sep 8, 2016
@mkassner mkassner closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants