Refactor to use a single non-dynamic script (#1)

Prior to this commit, a separate backup script was generated for each
database. This commit replaces all of that with a single bash script
that can backup an arbitrary list of databases.

Author: supercow

files/puppet_enterprise_database_backup.sh

@@ -0,0 +1,49 @@
+#!/bin/bash
+
+BACKUPDIR=/opt/puppetlabs/server/data/postgresql/9.4/backups
+LOGDIR=/var/log/puppetlabs/pe_databases_backup
+
+while [[ $# -gt 0 ]]; do
+  arg="$1"
+  case $arg in
+    -t)
+      BACKUPDIR="$2"
+      shift; shift
+      ;;
+    -l)
+      LOGDIR="$2"
+      shift; shift
+      ;;
+    *)
+      DATABASES="${DATABASES} $1"
+      shift
+      ;;
+  esac
+done
+
+if [[ -z "${DATABASES}" ]]; then
+  echo "Usage: $0 [-l LOG_DIRECTORY] [-t BACKUP_TARGET] <DATABASE1> [DATABASE...]"
+  exit 1
+fi
+
+for db in $DATABASES; do
+  echo "Starting dump of database: ${db}" >> ${LOGDIR}/${db}.log 2>&1
+
+  if [ ${db} == "pe-classifier" ]; then
+    #Save space before backing up by clearing unused node_check_ins table
+    /opt/puppetlabs/server/bin/psql -d pe-classifier -c 'TRUNCATE TABLE node_check_ins'
+    if [ $? != 0 ]; then
+      echo "Failed to truncate node_check_ins table."
+    fi
+  fi
+
+  /opt/puppetlabs/server/bin/pg_dump -Fc ${db} -f ${BACKUPDIR}/${db}_`date +%m_%d_%y_%H_%M`.bin >> ${LOGDIR}/${db}.log 2>&1
+
+  result=$?
+  if [[ $result -eq 0 ]]; then
+    echo "Completed dump of database: ${db}" >> ${LOGDIR}/${db}.log 2>&1
+  else
+    echo "Failed to dump database ${db}. Exit code is: ${result}" >> ${LOGDIR}/${db}.log 2>&1
+    exit 1
+  fi
+done

manifests/backup.pp

@@ -1,44 +1,19 @@
 define pe_databases::backup (
   Array[String] $databases_to_backup = [ 'pe-activity', 'pe-classifier', 'pe-postgres', 'pe-puppetdb', 'pe-rbac', 'pe-orchestrator' ],
-  String $backup_directory           = '/opt/puppetlabs/server/data/postgresql/9.4/backups',
-  String $script_directory           = '/opt/puppetlabs/pe_databases/scripts',
   String $minute                     = '30',
   String $hour                       = '23',
   String $weekday                    = '*',
-  String $logging_directory          = '/var/log/puppetlabs/pe_databases_backup',
 ) {
 
-  ensure_resource( 'file', [ '/opt/puppetlabs/pe_databases', $script_directory, $backup_directory ],
-    { 'ensure' => 'directory' }
-  )
-
-  ensure_resource( 'file', $logging_directory,
-    { 'ensure' => 'directory',
-       'owner' => 'pe-postgres',
-       'group' => 'pe-postgres', }
-  )
-
-  $script_path = "${script_directory}/puppet_enterprise_database_${databases_to_backup}_backup.sh"
-
-  file { $script_path :
-    ensure  => file,
-    content => epp('pe_databases/puppet_enterprise_database_backup.sh.epp',
-                   { databases_to_backup => $databases_to_backup,
-                     logging_directory   => $logging_directory,
-                     backup_directory    => $backup_directory,
-                   }),
-    owner   => 'pe-postgres',
-    group   => 'pe-postgres',
-    mode    => '0750',
-    before  => Cron["puppet_enterprise_database_backup_${databases_to_backup}"],
-  }
+  $db_string = join($databases_to_backup, " ")
 
   cron { "puppet_enterprise_database_backup_${databases_to_backup}":
-    ensure   => present,
-    command  => $script_path,
-    user     => 'pe-postgres',
-    minute   => $minute,
-    hour     => $hour,
-    weekday  => $weekday,
+    ensure  => present,
+    command => "${pe_databases::backup_script_path} -l ${pe_databases::backup_logging_directory} -t ${pe_databases::backup_directory} ${db_string}",
+    user    => 'pe-postgres',
+    minute  => $minute,
+    hour    => $hour,
+    weekday => $weekday,
+    require => File['puppet_enterprise_db_backup_script'],
   }
 }

manifests/init.pp

@@ -20,6 +20,9 @@
   ],
   Boolean $manage_database_maintenance = true,
   Boolean $manage_postgresql_settings  = true,
+  String $backup_directory             = '/opt/puppetlabs/server/data/postgresql/9.4/backups',
+  String $backup_script_path           = '/opt/puppetlabs/pe_databases/scripts/puppet_enterprise_database_backup.sh',
+  String $backup_logging_directory     = '/var/log/puppetlabs/pe_databases_backup',
 ) {
 
   if $manage_database_maintenance {
@@ -31,6 +34,26 @@
   }
 
   if !empty($databases_and_backup_schedule) {
+    ensure_resource( 'file', [ '/opt/puppetlabs/pe_databases', '/opt/puppetlabs/pe_databases/scripts', $backup_directory ],
+      { 'ensure' => 'directory' }
+    )
+
+    ensure_resource( 'file', $backup_logging_directory,
+      { 'ensure' => 'directory',
+         'owner' => 'pe-postgres',
+         'group' => 'pe-postgres', }
+    )
+
+
+    file { 'puppet_enterprise_db_backup_script' :
+      ensure => file,
+      owner  => 'pe-postgres',
+      group  => 'pe-postgres',
+      mode   => '0750',
+      path   => $backup_script_path,
+      source => 'puppet:///modules/pe_databases/puppet_enterprise_database_backup.sh',
+    }
+
     $databases_and_backup_schedule.each | Hash $dbs_and_schedule | {
       pe_databases::backup{ "${dbs_and_schedule['databases']}" :
         databases_to_backup => $dbs_and_schedule['databases'],