Skip to content

Add support for Debian 13 (trixie) #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

Add support for Debian 13 (trixie) #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data/os/Debian/11.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
# Defaults for Debian Bullseye (11)

postgresql::globals::python_package_name: 'python3-psycopg2'
Copy link
Collaborator

@bastelfreak bastelfreak Sep 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change broke the tests. And I don't know why a Debian 11 change is in the Debian 13 PR. The default for Debian 11 is set at https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/manifests/params.pp#L97 . But that default seems to be wrong, because the actual package name is python3-psycopg2 ? See https://packages.debian.org/search?suite=bullseye&searchon=names&keywords=python3-psycopg2

I think the issue here is that Debian 11 was added to metadata.json without proper (acceptance) tests and nobody used the python extension, so people didn't notice it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the code in the module for debian 11 was wrong for years?

It appears that way. In #1557 (comment) I wonder why I stated that there as a python-psycopg2 for Debian 11.

This change fixed the code, but in the wrong place

Correct. Including this here is weird: it negates the code we have for it:

puppetlabs-postgresql/manifests/params.pp

Lines 166 to 170 in b85be45

if $_ubuntu_2204 or $_debian_11 {
$python_package_name = pick($python_package_name, 'python3-psycopg2')
} else {
$python_package_name = pick($python_package_name, 'python-psycopg2')
}

And then all your other observations are also correct.

1 change: 1 addition & 0 deletions manifests/globals.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@
'10' => '11',
'11' => '13',
'12' => '15',
'13' => '17',
default => undef,
},
'Ubuntu' => $facts['os']['release']['major'] ? {
Expand Down
3 changes: 2 additions & 1 deletion metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@
"operatingsystemrelease": [
"10",
"11",
"12"
"12",
"13"
]
},
{
Expand Down