Skip to content

Adding postgresql class with $databases hash for Hiera #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adding postgresql class with $databases hash for Hiera #467

wants to merge 1 commit into from

Conversation

andyleejordan
Copy link

Will create postgresql::server::db resources using Hiera from the
postgresql::databases hash. Can totally add other resources this easily
in the future.

Will create postgresql::server::db resources using Hiera from the
postgresql::databases hash. Can totally add other resources this easily
in the future.
@igalic
Copy link
Contributor

igalic commented Aug 11, 2014

I'm a bit unhappy with this naming, and the lack of documentation. It is however a very good start for discussion. It's also related to

#431
#465
#468

@andyleejordan
Copy link
Author

Every PR is the start of a discussion! Would you prefer postgresql::db? I'll look into if it's possible to add it to the server class instead; I also quite like #431's style of a class under server to create the resources. I can do that and add documentation soon.

@andyleejordan
Copy link
Author

Eh on the other hand that'll result in a lot of classes. Perhaps this base class for wrapping all the resources would be most handy. Is there a subset of resources it would be best to add and document, or should I just go for them all?

Also: tests. Will add tests.

@antaflos
Copy link
Contributor

I really don't think this module (or any "component" module or "base block") should concern itself with Hiera or other external interfaces. That is the job of a profile or wrapper class.

A discussion on a similar proposal for the puppetlabs-apache module was held here: puppetlabs/puppetlabs-apache#794

@andyleejordan
Copy link
Author

Hm they have some interesting points. I've liked having minimal implementation code (at this point everything is done with Hiera and modules, I've had no need for wrappers) but abstracting the interfaces the wrappers is smart. Aight, I think I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants