Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This pull request fixes an augeas warning #935

Merged
merged 2 commits into from Jan 30, 2018

Conversation

iakovgan
Copy link
Contributor

@iakovgan iakovgan commented Nov 9, 2017

If the folder /etc/sysconfig/pgsql/postgresql contains files other than in bash format (conf for example), augeas shoows warning for both varibles.

Warning: Augeas[override PGDATA in /etc/sysconfig/pgsql/postgresql](provider=augeas): Loading failed for one or more files, see debug for /augeas//error output
Warning: Augeas[override PGPORT in /etc/sysconfig/pgsql/postgresql](provider=augeas): Loading failed for one or more files, see debug for /augeas//error output

I suggest this fix to avoid warning. Also it makes more sence to load only one file in augeas than all files in sysconfig/pgsql/ directory .

If there are files other than bash style config in /etc/sysconfig/pgsql/postgresql, augeas will throw exception
```
Warning: Augeas[override PGDATA in /etc/sysconfig/pgsql/postgresql](provider=augeas): Loading failed for one or more files, see debug for /augeas//error output
```
This commit fixes the issue.
Avoid useless loading of all files by augeas
@david22swan david22swan merged commit f7374d6 into puppetlabs:master Jan 30, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Feb 3, 2022
This pull request fixes an augeas warning
@Ramesh7 Ramesh7 added the bugfix label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants