(maint) - Various fixes in order to get the test’s running

- Code has been put in place so that when test’s are run on GCP relevant files are taking from the google cloud storage rather than artifactory
- A temporary fix has been put in place to have all tests be run on sqlserver2016, pending the ability to set the sql version within the workflows

Author: david22swan

.github/workflows/pr_test.yml

@@ -5,7 +5,8 @@ on: [pull_request]
 env:
   HONEYCOMB_WRITEKEY: 7f3c63a70eecc61d635917de46bea4e6
   HONEYCOMB_DATASET: litmus tests
-
+  SERVICE_URL: https://facade-openssh-windows-6f3kfepqcq-ew.a.run.app/v1/provision
+  
 jobs:
   setup_matrix:
     name: "Setup Test Matrix"
@@ -55,7 +56,7 @@ jobs:
       id: get-matrix
       run: |
         if [ '${{ github.repository_owner }}' == 'puppetlabs' ]; then
-          buildevents cmd $TRACE_ID $STEP_ID matrix_from_metadata -- bundle exec matrix_from_metadata_v2
+          echo  "::set-output name=matrix::{'platforms':[{'label':'win2016-sql2016','provider':'provision::provision_service','image':'windows-2016-core'}],'collection':['puppet7-nightly','puppet6-nightly']}"
         else
           echo  "::set-output name=matrix::{}"
         fi

provision.yaml

@@ -5,26 +5,34 @@ release_checks_sql_2012:
   provisioner: abs
   images: ['win-2012r2-x86_64']
   vars: 'sqlversion: sqlserver_2012'
-release_checks_sql_2014_parity:
+release_checks_sql_2014_nightly:
   provisioner: abs
   images: ['win-2012r2-x86_64']
   vars: 'sqlversion: sqlserver_2014'
 release_checks_sql_2014:
   provisioner: abs
   images: ['win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64']
   vars: 'sqlversion: sqlserver_2014'
-release_checks_sql_2016_parity:
+release_checks_sql_2016_nightly:
   provisioner: abs
-  images: ['win-2012r2-x86_64', 'win-2016-x86_64']
+  images: ['win-2016-x86_64']
   vars: 'sqlversion: sqlserver_2016'
 release_checks_sql_2016:
   provisioner: abs
   images: ['win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64']
   vars: 'sqlversion: sqlserver_2016'
+release_checks_sql_2017_nightly:
+  provisioner: abs
+  images: ['win-2016-x86_64']
+  vars: 'sqlversion: sqlserver_2017'
 release_checks_sql_2017:
   provisioner: abs
   images: ['win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64']
   vars: 'sqlversion: sqlserver_2017'
+release_checks_sql_2019_nightly:
+  provisioner: abs
+  images: ['win-2019-x86_64']
+  vars: 'sqlversion: sqlserver_2019'
 release_checks_sql_2019:
   provisioner: abs
   images: ['win-2012r2-x86_64', 'win-2016-x86_64', 'win-2019-x86_64']

spec/acceptance/sqlserver_config_spec.rb

@@ -12,7 +12,7 @@
 describe 'sqlserver::config test' do
   def ensure_sqlserver_instance(inst_name, ensure_val = 'present')
     pp = <<-MANIFEST
-      sqlserver_instance{'#{inst_name}':
+    sqlserver_instance{'#{inst_name}':
       ensure                => '#{ensure_val}',
       source                => 'H:',
       features              => ['DQ', 'FullText', 'Replication', 'SQLEngine'],

spec/acceptance/sqlserver_instance_spec.rb

@@ -9,7 +9,7 @@ def new_random_instance_name
 end
 
 describe 'sqlserver_instance' do
-  version = sql_version?
+  version = '2016' # sql_version?
 
   def ensure_sqlserver_instance(features, inst_name, ensure_val = 'present', sysadmin_accounts = "['Administrator']")
     pp = <<-MANIFEST

spec/acceptance/sqlserver_tsql_spec.rb

@@ -4,7 +4,7 @@
 require 'securerandom'
 require 'erb'
 
-version = sql_version?
+version = '2016' # sql_version?
 
 # database name
 db_name = ('DB' + SecureRandom.hex(4)).upcase

spec/acceptance/z_last_sqlserver_features_spec.rb

@@ -4,7 +4,7 @@
 require 'erb'
 require 'json'
 
-version = sql_version?
+version = '2016' # sql_version?
 
 describe 'sqlserver_features', if: version.to_i != 2012 do
   def ensure_sql_features(features, ensure_val = 'present')

spec/spec_helper_acceptance_local.rb

@@ -27,22 +27,18 @@ class Helper
     Helper.instance.run_shell('puppet module install puppetlabs/mount_iso')
     Helper.instance.run_shell('puppet module install puppet/archive')
 
-    if ENV['CLOUD_CI'] == 'true'
-      Helper.instance.run_shell("gsutil cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{WIN_2012R2_ISO} /tmp/")
-      Helper.instance.run_shell("gsutil cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2012_ISO} /tmp/")
-      Helper.instance.run_shell("gsutil cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2014_ISO} /tmp/")
-      Helper.instance.run_shell("gsutil cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2016_ISO} /tmp/")
-      Helper.instance.run_shell("gsutil cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2017_ISO} /tmp/")
-      Helper.instance.run_shell("gsutil cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2019_ISO} /tmp/")
-
+    if ENV['GITHUB_ACTIONS'] == 'true'
+      Helper.instance.run_shell("gsutil -q cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{WIN_2012R2_ISO} C:/Windows/Temp/#{WIN_2012R2_ISO}")
       iso_opts = {
-        folder: '/tmp',
+        folder: 'C:/Windows/Temp',
         file: WIN_2012R2_ISO,
         drive_letter: 'I',
       }
       mount_iso(iso_opts)
 
-      base_install(sql_version?, '/tmp')
+      # Temp fix to prove code works
+      base_install('2016', 'C:/Windows/Temp')
+      # base_install(sql_version?, 'C:/Windows/Temp')
     else
       # For Internal testing
       iso_opts = {
@@ -83,51 +79,63 @@ def mount_iso(opts = {})
   folder = opts[:folder]
   file = opts[:file]
   drive_letter = opts[:drive_letter]
-
-  pp = <<-MANIFEST
-  $p_src  = '#{folder}/#{file}'
-  $source = 'C:\\#{file}'
-  archive { $source:
-    ensure => present,
-    source => $p_src,
-    user   => 0,
-    group  => 0,
-  }
-  mount_iso{$source:
-    require      => Archive[$source],
-    drive_letter => '#{drive_letter}',
-  }
-  MANIFEST
+  pp = if ENV['GITHUB_ACTIONS'] == 'true'
+         <<-MANIFEST
+          mount_iso{'#{folder}/#{file}':
+            drive_letter => '#{drive_letter}',
+          }
+        MANIFEST
+       else
+         <<-MANIFEST
+          $p_src  = '#{folder}/#{file}'
+          $source = 'C:\\#{file}'
+          archive { $source:
+            ensure => present,
+            source => $p_src,
+            user   => 0,
+            group  => 0,
+          }
+          mount_iso{$source:
+            require      => Archive[$source],
+            drive_letter => '#{drive_letter}',
+          }
+        MANIFEST
+       end
   Helper.instance.apply_manifest(pp)
 end
 
 def base_install(sql_version, resource_root)
   case sql_version.to_i
   when 2012
+    Helper.instance.run_shell("gsutil -q cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2012_ISO} C:/Windows/Temp/#{SQL_2012_ISO}") if ENV['GITHUB_ACTIONS'] == 'true'
     iso_opts = {
       folder: resource_root,
       file: SQL_2012_ISO,
       drive_letter: 'H',
     }
   when 2014
+    Helper.instance.run_shell("gsutil -q cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2014_ISO} C:/Windows/Temp/#{SQL_2014_ISO}") if ENV['GITHUB_ACTIONS'] == 'true'
     iso_opts = {
       folder: resource_root,
       file: SQL_2014_ISO,
       drive_letter: 'H',
     }
   when 2016
+    Helper.instance.run_shell("gsutil -q cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2016_ISO} C:/Windows/Temp/#{SQL_2016_ISO}") if ENV['GITHUB_ACTIONS'] == 'true'
     iso_opts = {
       folder: resource_root,
       file: SQL_2016_ISO,
       drive_letter: 'H',
     }
   when 2017
+    Helper.instance.run_shell("gsutil -q cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2017_ISO} C:/Windows/Temp/#{SQL_2017_ISO}") if ENV['GITHUB_ACTIONS'] == 'true'
     iso_opts = {
       folder: resource_root,
       file: SQL_2017_ISO,
       drive_letter: 'H',
     }
   when 2019
+    Helper.instance.run_shell("gsutil -q cp -r gs://artifactory-modules/puppetlabs-sqlserver/#{SQL_2019_ISO} C:/Windows/Temp/#{SQL_2019_ISO}") if ENV['GITHUB_ACTIONS'] == 'true'
     iso_opts = {
       folder: resource_root,
       file: SQL_2019_ISO,