Add rule for type holes #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be typed holes - a type hole sounds to me like a hole in a type, which is rather what type wildcards are. is |
|
Perhaps we could use the |
|
I think that could work |
Type holes will be highlighted using the ".invalid .illegal" style.
This changes the scope for typed holes from `invalid.illegal.typed-hole` to `entity.name.function.typed-hole`.
ianbollinger
force-pushed
the
type-holes
branch
from
b406313 to
9ddb7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type holes will be highlighted using the ".invalid .illegal" style.