Better highlighting #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script appends a .purescript so they're not necessary
Also add todo.txt
This should stop type classes from appearing differently based on context.
Now types in foreign imports get highlighted as types, not as data constructors
- Remove 'declaration.class' as it gives weird highlighting, replaced with 'declaration.typeclass' - Highlight type signatures properly inside class declarations - Handle left-pointing fat arrows, for superclasses
eg: <- in do blocks, -> in case statements Unfortunately, -> the function type constructor is now highlighted like a keyword. I couldn't work out how to avoid this.
|
Thanks for the PR, this looks really nice. Checking in the grammar file should be fine I think and it's also okay to note something in the license file. I should mention though that I'm not really using Atom much these days so if you're interested in improving this I would be happy to transfer ownership of the repo and let you take over. |
* Add language-haskell's LICENSE * Don't use a postinstall script (because the grammar file is checked in now) * Add a note to the grammar generating script about how to regenerate
|
Cool, thanks. I think this is good to merge now. I'm actually not an Atom user either, I'm just trying to improve PureScript highlighting on Github. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs purescript/pursuit#115
I started with the Haskell grammar (from here) and made some tweaks. Notably:
forallis now highlighted properly as a keyword in type signatures<=(for when there are superclasses) are now highlighted properly.->incase, or<-indo, are highlighted as keywords. Unfortunately the->function type constructor is highlighted as a keyword too, I couldn't work out how to stop this from happening.Unresolved questions:
grammars/purescript.csonis generated by a script. Would you rather it were not checked in?