Skip to content

Grammar update 2 fix1 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 16, 2022

Conversation

wclr
Copy link
Contributor

@wclr wclr commented Aug 15, 2022

Fix for issue in #56 with px = Proxy :: Proxy "fdsfsdf"

image

@wclr
Copy link
Contributor Author

wclr commented Aug 15, 2022

Oh this git, I wonder why it shows the conflict.

@wclr wclr mentioned this pull request Aug 15, 2022
@mikesol
Copy link

mikesol commented Aug 16, 2022

I'll use this for a week-ish and report back if I see anything wrong. Ping me if you don't hear from me!

@mikesol
Copy link

mikesol commented Aug 16, 2022

Also confirming that the file in question is now correctly highlighted.
Screen Shot 2022-08-16 at 6 28 14 AM

@nwolverson
Copy link
Contributor

Going to merge this right away since the version on master is known to be broken, but not push a release immediately.

@wclr if you have any further refinements / issues noticed can you start from master

@nwolverson nwolverson merged commit b5c4395 into purescript-contrib:master Aug 16, 2022
@mikesol
Copy link

mikesol commented Aug 22, 2022

It looks like there's still a tiny bug. This use of triple-quotes is likely mega-super-rare, though.
Screen Shot 2022-08-22 at 9 57 44 AM
.

@nwolverson
Copy link
Contributor

@mikesol is that triple quotes only being an issue for type level strings?

@mikesol
Copy link

mikesol commented Aug 22, 2022

@mikesol is that triple quotes only being an issue for type level strings?

yup, only type-level strings.
here's the term-level working correctly:
Screen Shot 2022-08-22 at 12 29 03 PM

@wclr
Copy link
Contributor Author

wclr commented Aug 23, 2022

Will take a look.

@wclr
Copy link
Contributor Author

wclr commented Aug 23, 2022

Have fixed it in #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants