Skip to content

Conversation

AidanDelaney
Copy link
Contributor

@natefaubion provided me with a nice neat example of using codecs that made it easy for me to get my head around the module. I think the example might help to orient new users of the module so I've added it to the README.

@damncabbage
Copy link

This looks good; would it possible to get this change in? I too was confused when I first started looking at the Argonaut pieces (having never used the Scala original or Haskell port).

@thomashoneyman
Copy link
Contributor

@AidanDelaney I'm sorry that this is the first time we're getting back to this -- contributors have been backlogged for quite some time, but I'm going through and taking care of older issues and PRs.

I think this is a valuable addition to the library. Quick note: the code snippet will need to be updated for 0.12, where StrMap has been deprecated in favor of a more accurate Foreign.Object type.

I'm going to leave this issue live for another week. If there hasn't been activity, then I'll merge and then perform the update to 0.12.

Thanks!

@thomashoneyman thomashoneyman self-assigned this Nov 11, 2018
@thomashoneyman thomashoneyman added the type: documentation Improvements or additions to documentation. label Nov 11, 2018
@thomashoneyman
Copy link
Contributor

I've actually just gone ahead and updated this for 0.12 and fixed the conflicts. Thanks for adding this to the documentation!

@thomashoneyman thomashoneyman merged commit 82efbd5 into purescript-contrib:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation.
Development

Successfully merging this pull request may close these issues.

3 participants