Skip to content

Conversation

adkelley
Copy link
Contributor

@adkelley adkelley commented Jun 1, 2018

No description provided.

@kritzcreek
Copy link

Thanks, the reason this fails is because the newest purescript-node-bin requires at least node-8. The way we fixed this in the other repos is by changing the .travis.yml to point at nodejs: stable.

Fwiw this library already works fine on 0.12, it's just not tested on CI against that compiler version.

@adkelley
Copy link
Contributor Author

adkelley commented Jun 2, 2018

Got it. If I understand you correctly, is this just a matter of changing .travis.yml to point to nodejs: stable? I'd like to get this into psc-package-sets because it's a dependency for purescript-webaudio

@garyb
Copy link
Member

garyb commented Jun 2, 2018

I don't think you need to do anything to update it for a package set - it needed no code changes for 0.12 and has no dependencies, so it should be possible to just add it straight in.

@thomashoneyman
Copy link
Contributor

Hey folks! This is a transitive dependency for a library of ours at CitizenNet. I looked at the Travis failure and it does look like switching o node "stable" will let that run (I've seen a similar problem in other repositories).

@adkelley any chance you could update the PR with that change and then if CI passes we can get this merged?

Thanks!

@kritzcreek
Copy link

@thomashoneyman This library works fine as is on 0.12, so don't worry about this PR, just use the latest version.

@thomashoneyman
Copy link
Contributor

Sheesh, I was just reading the source and Bower file and noticed that there's nothing to do. Thanks!

@thomashoneyman
Copy link
Contributor

Merging this to tie up loose ends and will fix the Travis build as well.

@thomashoneyman thomashoneyman merged commit 764e9de into purescript-contrib:master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants