Skip to content

Removes external fail-able dependencies #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Removes external fail-able dependencies #21

wants to merge 2 commits into from

Conversation

AlexaDeWit
Copy link
Contributor

In response to #20 and #19

This pull request removes all dependencies to external NPM packages, as well as a dependency to node in the form of a require to util.

Another library will be released to provide this functionality elsewhere, and this PR will be updated to include that. This fact should probably included in the release notes.

Also I bumped the package.json version to 9, since it is included here and I assume that would be the version number associated here.

@AlexaDeWit
Copy link
Contributor Author

In retrospect, my deriving library will depend on this version, and thus a release will be needed before that.

I'm not sure the best way to inform users of the API breaking change, but I think a release is warranted first, and I should have the new version ready pretty soon.

@AlexaDeWit
Copy link
Contributor Author

Can you by chance email me when the v9 release goes through?

I will need to do major release updates to several other libraries I maintain, so it's best I notice asap

<3

@jacereda
Copy link
Collaborator

Sure, just waiting until @athanclark decides what primitives would be needed on his side, I'll make sure to notify you.

@AlexaDeWit
Copy link
Contributor Author

Thanks, really appreciate that.

@athanclark
Copy link
Collaborator

athanclark commented Dec 15, 2018

I just finished verifying everything. I've got a few cosmetic considerations (argument placing to match intuitive formats, for instance, in foldr), and one semantic one - javascript's foo.subarray(..) method isn't semantically consistent - I'm going to make this library's implementation semantically consistent and dual to slice for end-users.

I'm trying to get this PR published today - the tests are pretty much total, and they've already exposed a number of bugs.

Edit: Just published: #23

@AlexaDeWit AlexaDeWit closed this Dec 16, 2018
@AlexaDeWit
Copy link
Contributor Author

Closing this PR as the work it introduces is duplicated by #23

Thanks Athan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants