Skip to content

Split getters and setters into big and little endian. Change PureScript #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Split getters and setters into big and little endian. Change PureScript #6

merged 1 commit into from
Oct 18, 2016

Conversation

zaquest
Copy link
Contributor

@zaquest zaquest commented Sep 30, 2016

type for Uint32 operations to Int53.

@jacereda
Copy link
Collaborator

Looks good, but I would keep the big-endian names without suffix to avoid bumping the major version.

@jacereda
Copy link
Collaborator

On a second though, the UInt32 fetcher was quite silly with an Int return type, so maybe we should bump.

@zaquest
Copy link
Contributor Author

zaquest commented Oct 2, 2016

I've written this package. It provides exactly the UInt32 type, maybe it could be used instead of Int53. It's poorly documented though - I'm not good at English. But I'll try adopting some more of docstrings from purescript-int-53 later.

@jacereda
Copy link
Collaborator

jacereda commented Oct 2, 2016

Sounds good, I guess it's more appropriate here than the -int53 package.

@jacereda
Copy link
Collaborator

jacereda commented Oct 4, 2016

The changes to use Data.UInt are in the zaquest-int53_and_endianness, waiting for the -quickcheck/-transformers fix to merge to master.

@jacereda jacereda merged commit b7bb914 into purescript-contrib:master Oct 18, 2016
@jacereda
Copy link
Collaborator

Should be merged now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants