Skip to content

update CI Purescript version #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peterbecich
Copy link
Contributor

Update Github Actions from Purescript 0.14.0-rc5 to 0.14.0


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

Comment on lines 18 to 19
with:
purescript: "0.14.0-rc5"
purescript: "0.14.0"
Copy link
Contributor

@thomashoneyman thomashoneyman Mar 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could actually remove this altogether, as setup-purescript will pull in the latest.

  uses: purescript-contrib/setup-purescript@main
- with:
-   purescript: "0.14.0"

@peterbecich peterbecich force-pushed the ci-purescript-version branch from 187ae9a to e824648 Compare March 7, 2021 07:57
CHANGELOG.md Outdated
@@ -28,6 +28,7 @@ Other improvements:
- Removed `purescript-generics` dependency (#76 by @vyorkin)
- Changed default branch to `main` from `master`
- Updated to comply with Contributors library guidelines by adding new issue and pull request templates, updating documentation, and migrating to Spago for local development and CI (#121 by @maxdeviant)
- Remove CI pin to 0.14.0-rc5 compiler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I didn't notice this before, but this would be a part of the 0.14 updates and we generally wouldn't acknowledge this in the changelog. After all, we only moved to the CI pin on the main branch while making updates, and now we're reverting that temporary change.

from 0.14.0-rc5 to 0.14.0
@peterbecich peterbecich force-pushed the ci-purescript-version branch from e824648 to 2450241 Compare March 7, 2021 20:39
@thomashoneyman thomashoneyman merged commit 5c1a44e into purescript-contrib:main Mar 7, 2021
@peterbecich peterbecich deleted the ci-purescript-version branch March 7, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants