Skip to content

Make Selector instance of Semigroup #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vyorkin
Copy link
Collaborator

@vyorkin vyorkin commented Jul 1, 2018

Allows to write this:

(p <> a) ? do
  display block

Rendering produces:

p, a { display: block }

Resolves #80

@vyorkin vyorkin force-pushed the feature/selector-semigroup branch from fdddbcb to a0e0a31 Compare July 1, 2018 17:42
@thomashoneyman thomashoneyman changed the base branch from master to main October 6, 2020 03:09
@JordanMartinez
Copy link
Contributor

Without knowing too much about this library, I'm in favor of closing this PR. I think the combinator idea itself is worth adding, but not as this implementation. Perhaps it would be its own Combinators module. AFAICT, using , to combine two Selectors together is just one possible Semigroup instance. I imagine that the separator could also be >, +, or combinators like that.

@JordanMartinez
Copy link
Contributor

Closing this PR due to the reasons stated above.

@vyorkin
Copy link
Collaborator Author

vyorkin commented Oct 3, 2021

using , to combine two Selectors together is just one possible Semigroup instance. I imagine that the separator could also be >, +, or combinators like that

Good point, totally agree

@vyorkin vyorkin deleted the feature/selector-semigroup branch October 3, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make Selector a Semigroup
2 participants