Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ReactRender with IsReactElement #137

Merged
merged 1 commit into from
Mar 17, 2018

Conversation

natefaubion
Copy link
Contributor

Fixes #131 #127

@ethul
Copy link
Contributor

ethul commented Mar 17, 2018

Looks great! Thanks for this update.

Just out of curiosity, should fragment be exported as well as fragmentWithKey?

@natefaubion
Copy link
Contributor Author

I did not export fragment because that's what toElement [ ... ] is. I don't think there is a reason to expose the ReactClass directly.

@ethul
Copy link
Contributor

ethul commented Mar 17, 2018

Gotcha. Sounds good. Thanks again.

@ethul ethul merged commit 523f5a0 into purescript-contrib:master Mar 17, 2018
@paulyoung
Copy link
Contributor

Perhaps this would help with discoverability.

fragment :: Array ReactElement -> ReactElement
fragment = toElement

Not being able to find fragment led to someone using fragmentWithKey instead, and I eventually found this thread.

@ethul
Copy link
Contributor

ethul commented Jul 22, 2018

I can see this being handy to match up with React.Fragment in JS. However, I am open to opinions on this. If we all think this would be helpful, @paulyoung can you please open a new issue for this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants