Add file descriptor features (open, read, next, write, append, flush, close) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dysinger
force-pushed
the
add-sync-open-read-write-close
branch
from
e137739 to
3e0fcf5
Compare
dysinger
force-pushed
the
add-sync-open-read-write-close
branch
from
3e0fcf5 to
42c1767
Compare
|
I haven't used or worked on this library, but looks good to me. I think the wrapper libs need to be very low-level so lots of authors can build on top of them. If they get too opinionated, that encourages fragmentation. @joneshf may be a good one to check here. |
|
Well low-level is what I've tried to do here. If it's not low-level enough then let's talk about it. I'm simply translating, with as little code as possible, the synchronous file handling bits from Node.js "fs". |
|
Yes, I agree, looked at the perfect level to me. 👍 |
|
Looks good to me too at a glance, but sorry, I'm a bit busy tonight - will try to get some time to review/merge tomorrow! |
|
Thanks! |
garyb
added a commit
that referenced
this pull request
Jan 14, 2015
Add file descriptor features (open, read, next, write, append, flush, close)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review. Let me know if you like anything different. :)